Bugzilla – Full Text Bug Listing
| Summary: | [ImageSupport] Missing label icons in the editor area | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Jacques LESCOT <jlescot> | ||||
| Component: | General | Assignee: | Cherie Revells <crevells> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P1 | CC: | ahunter.eclipse, me, min123 | ||||
| Version: | 2.1 | ||||||
| Target Milestone: | 2.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 214160 | ||||||
| Bug Blocks: | 189608, 211851 | ||||||
| Attachments: |
|
||||||
The ECore editor is generated by the tooling. Cherie, was there any changes the tooling needed to adopt? Yes, the tooling should make changes to generate with the new WrappingLabel otherwise they could have some issues. I am hoping there won't be too many issues with using the deprecated WrapLabel, but it's impossible to guarantee that since it extends the new WrappingLabel. I'll take a look at the ECore editor to see what the problem is. In fact, I initially identified this problem in the Ecore Tools component I am working on. In my case, I manually replaced all the WrapLabel occurences with WrappingLabel references : I did it manually because I could not regenerate as the templates were not updated in consequence to support WrappingLabel. So the problem is also present with icon labels using the WrappingLabel class. I just tried the ecore editor example provided with GMF to see whether the problem was only on my side, which was not the case. While trying to regenerate using *.gmfgen model, it seems that templates still generate dependencies to the WrapLabel class : is it planned to completely remove those references into WrappingLabel ones ? There is an enhancement logged against the generation team to make these changes. See Bug 206582 . I just tried the GMF ECore Editor using GMF from HEAD and the icon appears fine for me. I have never seen this problem before. Are you sure there is not an IconProvider interfering somehow? Jacques, can you try putting a breakpoint in EPackageNameEditPart.getLabelIcon() and then try creating an EPackage on the diagram? I can reproduce the bug while installing a new Eclipse 3.4M3 version with necessary dependencies (GMF 2.1M3, EMF 2.4M3, GEF 3.4M3, MDT OCL 1.2M3, EMF Query/Transaction/Validation 1.2M3). When I add a breakpoint on the EPackageNameEditPart.getLabelIcon() method, it correctly stops at the line : - the parserElement is the model element associated with the EPackage I have created - it correcly returns an Image (you can see in the attached screenshot that there is a space between the label and the parent container corresponding to the icon size, but it is not visible. I found the origin of the bug : antialiasing. When I disable antialiasing, icons are correctly displayed. I am running under Windows XP, and I had never had problems with antialiasing before. That's odd. I have Windows XP as well and it works fine with antialiasing for me. (In reply to comment #9) > That's odd. I have Windows XP as well and it works fine with antialiasing for > me. > I have duplicated this issue on my XP machine. Ok, I can reproduce this now too. It has something to do with one of the GMF dependencies. With the current GMF code and a 3-month old Eclipse target, the problem does not exist for me, but with the lastest Eclipse target it does. I will investigate. It doesn't seem to have to do with the new WrappingLabel though, I can reproduce it with the old WrapLabel as well. Reproduced in SWT snippet. Created Bug 214160 against SWT component. Marking resolved since the SWT bug has been fixed. [target cleanup] 2.1 M5 was the original target milestone for this bug [GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug |
Created attachment 82874 [details] Screenshot that describe the bug Build ID: I20071101-2000 Steps To Reproduce: Since the recent changes (WrapLabel has been replaced by WrappingLabel) it seems that icon label are no longer visible in the editor area, whereas it is visible in the outline thumbnail view. The problem is present in the ecore diagram provided as example and we have similar issue in our GMF editors. More information: