Summary: | [Apply Patch] cancel save modified resource does not cancel apply patch | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Benno Baumgartner <benno.baumgartner> | ||||||||
Component: | CVS | Assignee: | platform-cvs-inbox <platform-cvs-inbox> | ||||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||||
Severity: | minor | ||||||||||
Priority: | P5 | CC: | b.muskalla, Szymon.Brandys, tomasz.zarna | ||||||||
Version: | 3.3 | Keywords: | bugday, contributed | ||||||||
Target Milestone: | 3.4 M6 | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Whiteboard: | hasPatch | ||||||||||
Attachments: |
|
Description
Benno Baumgartner
2007-10-30 11:19:22 EDT
You're right Benno, I think we could add a similar dialog to the "Save Modified Resources" one, which you display prior refactoring i.e. a dialog with Ok/Cancel buttons only which would work as you suggested. Moreover, the "Save all modified resources automatically..." option is also a good example and we could use it too. Anyway, it's always a matter of how much time we would need to create a patch, but at least we should handle the "Cancel" button as you suggested (no Apply Patch dialog after hitting the button). Created attachment 90943 [details]
utilize return value of saveEditors
Little patch to cancel the operation when canceling the save dialog
Created attachment 90944 [details]
mylyn/context/zip
Created attachment 91169 [details]
Patch (API compatible)
Benjamin, your patch works fine but it breaks API compatibility (ie changing result type of an API method (including void) breaks compatibility). This is how we can acheive the same thing without breaking anything. What do you think?
hi Tomasz, for sure. I don't know why but I had in mind the class was internal. Seems I was a little bit confused at that evening. Go from me ;) The latest patch released to HEAD. Thanks Benjamin. Verified in I20080304-1113. |