Summary: | Spec clarification: Senders of PropertyChangeEvent.getProperty() should use equals, not == | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Nick Edgar <n.a.edgar> |
Component: | UI | Assignee: | Nick Edgar <n.a.edgar> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | Randy_Giffen |
Version: | 2.0 | ||
Target Milestone: | 2.0 F4 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Nick Edgar
2002-06-20 16:48:50 EDT
Need to fix up both org.eclipse.jface.util.PropertyChangeEvent.getProperty(), and org.eclipse.core.runtime.Preferences$PropertyChangeEvent.getProperty() Approved by arch team. Added the following to the spec for org.eclipse.jface.util.PropertyChangeEvent.getProperty(): * <p> * Warning: there is no guarantee that the property name returned * is a constant string. Callers must compare property names using * equals, not ==. Released. Randy and DJ, could you please review the change? Moving to Core to fix up org.eclipse.core.runtime.Preferences$PropertyChangeEvent.getPropertyName(). Sorry about the short notice before F4. Verified change in JFace. Fixed and released same change in Runtime. Minor point but the change in JFace is missing the </p> tag Added </p> tag |