Bug 20686

Summary: Install handlers are not being called on revert operations
Product: [Eclipse Project] Platform Reporter: Vlad Klicnik <klicnik>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Christophe Elek <celek>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P2    
Version: 2.0   
Target Milestone: 2.0.1   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Vlad Klicnik CLA 2002-06-19 16:36:38 EDT 
When you revert to a previos state, the install handlers for the features that 
are being unconfigured and (re)configured are not being called.
Comment 1 Vlad Klicnik CLA 2002-06-19 16:47:27 EDT 
This is a bad problem, but a scary change for F4, so will delay implementing it 
to a service release. 

It's impact will be limited to products using install handlers, and in 
particular those that want to execute some logic on configure and unconfigure 
operations. Workaround is to do all installation handling on install, and rely 
on the actual plugins being configured/ unconfigured to manage the presence/ 
absence of function.
Comment 2 Christophe Elek CLA 2002-07-18 14:57:34 EDT 
ConfiguredPolicy has now one configure and one unconfigure method which takes 3 args
The feature and 2 boolean
one for calling the install handler
one for creating an activity
All call to configure/unconfigure go through theses 2 methods except when
parsing previous state from XML file (goes to the model directly)

When reverting, we configure all the features that have to be configured, if
they are already configured nothing happens.
We unconfigure all the features that need to be unconfigured

The code is in ConfiguredSite.revertTo(IConfiguredSite...

tested with RedDot 1.0 + install handler
handler called during revert end restore
All regression tests are green