Bug 20534

Summary:	Plugin preference importer should intern strings
Product:	[Eclipse Project] Platform	Reporter:	DJ Houghton <dj.houghton>
Component:	Resources	Assignee:	DJ Houghton <dj.houghton>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2
Version:	2.0
Target Milestone:	2.0 F4
Hardware:	PC
OS:	All
Whiteboard:

Description DJ Houghton

2002-06-18 09:33:22 EDT

build 2002-06-17

When we import preferences for a plug-in, we send out the appropriate property 
change event. There was a case where the property change event listner was 
using == instead of equals() to check and see if the property that was changed 
was one in which they were interested. Since the importer does not have access 
to the constants to which it is comparing, perhaps the importer should look at 
interning the property name strings that it is setting.

Comment 1 Nick Edgar

2002-06-18 13:45:40 EDT

Please consider this as a candidate for F4.
Without this, the import feature will not work properly since several listeners 
assume they can use ==.  See bug 20471 for a list.

Comment 2 DJ Houghton

2002-06-18 14:19:18 EDT

After discussions we have decided that interning strings is the wrong answer 
and that people should not be relying on String identity in their property 
change listeners.

Closing.

Comment 3 DJ Houghton

2002-06-21 10:54:51 EDT

Re-opening bug report.

Comment 4 John Arthorne

2002-06-21 15:22:58 EDT

Applied fix.  We now intern all strings on preference import.  Test case added.  
Released.