Summary: | [codeassist] assert keyword should not be proposed when compliance level is set to 1.3 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Maxime Daniel <maxime_daniel> | ||||||
Component: | Core | Assignee: | Srikanth Sankaran <srikanth_sankaran> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | minor | ||||||||
Priority: | P3 | CC: | david_audel | ||||||
Version: | 3.4 | ||||||||
Target Milestone: | 3.5 M7 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Maxime Daniel
2007-09-12 08:30:41 EDT
Created attachment 128899 [details]
Proposed fix and tests
David, appreciate your review. Let me know if something is amiss. Thanks.
The fix is good but you should improve the regression test. The 1.3 and 1.4 behavior should be tested in two different methods. Currently if the test fails in 1.3, it is not possible to know if it fails also in 1.4. You should restore the options in a finally block to restore options even if an exception occurs. Created attachment 129035 [details]
Revised patch
Split test cases. Added more tests to cover all changed code blocks.
Comment on attachment 129035 [details]
Revised patch
The patch is good.
Released for 3.5M7. I released the revised patch. I found another bug in the same area but this is a separate problem: bug 269493. Verified for 3.5M7 using I20090426-2000 |