Bug 201312

Comment 1 Fabio Mancinelli 2007-08-28 18:23:07 EDT

Created attachment 77189 [details]
Patch to fix the bug

Removed the call to deprecated constructor and changed it to the suggested one.

Fabio (finished with the easy deprecation removal stuff :))

Comment 2 Chris Aniszczyk 2007-08-28 18:32:13 EDT

Mike, can you take a look at this and make sure nothing breaks ;)?

Comment 3 Mike Pawlowski 2007-08-29 09:07:17 EDT

Comment on attachment 77189 [details]
Patch to fix the bug

Unfortunately, this change breaks the schema and plug-in manifest editors :( . 
Details to follow.

Comment 4 Mike Pawlowski 2007-08-29 10:09:17 EDT

The following error occurs on editor open:

"Error opening the editor"

org.eclipse.core.runtime.AssertionFailedException: null argument:
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:84)
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:72)
	at org.eclipse.jface.text.rules.DefaultDamagerRepairer.<init>(DefaultDamagerRepairer.java:78)
	at org.eclipse.pde.internal.ui.editor.text.MultilineDamagerRepairer.<init>(MultilineDamagerRepairer.java:23)
	at org.eclipse.pde.internal.ui.editor.text.XMLConfiguration.getPresentationReconciler(XMLConfiguration.java:86)
	at org.eclipse.jface.text.source.SourceViewer.configure(SourceViewer.java:355)
...


The old constructor allowed a null scanner and relied on the XML comment attribute; whereas, the new constructor does not allow a null scanner.

Comment 5 Chris Aniszczyk 2007-08-29 10:11:00 EDT

Is this effectively a regression on the new constructor? What should we pass instead?

Comment 6 Mike Pawlowski 2007-08-29 10:56:15 EDT

Not a regression because the non-deprecated constructor never allowed null.
I'm guessing a scanner that returns the default text attribute that was discarded  should be passed in as a parameter (needs further investigation) 

Comment 7 Curtis Windatt 2008-11-17 09:59:09 EST

Returning to the inbox/bugday box.

Comment 8 Eclipse Genie 2018-12-12 17:51:31 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 9 Lars Vogel 2019-09-02 15:05:22 EDT

This bug has been marked as stalebug a while ago without any further interaction.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.

Comment 10 Lars Vogel 2019-09-02 15:10:22 EDT

This bug was marked as stalebug a while ago. Marking as worksforme.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.