Bug 201304

Summary:

ErrorReporter makes deprecated calls

Product:

[Eclipse Project] PDE

Reporter:

Chris Aniszczyk <caniszczyk>

Component:

Assignee:

Fabio Mancinelli <fm>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

baumanbr

Version:

3.4

Keywords:

bugday, contributed

Target Milestone:

3.4 M2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
A patch to fix the bug	none
mylyn/context/zip	none

Description Chris Aniszczyk

2007-08-27 14:58:49 EDT

org.eclipse.pde.internal.core.builders.ErrorReporter.java

Severity and Description	Path	Resource	Location	Creation Time	Id
The method connect(IPath, IProgressMonitor) from the type IFileBufferManager is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders	ErrorReporter.java	line 71	1188224978203	132719
The method disconnect(IPath, IProgressMonitor) from the type IFileBufferManager is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders	ErrorReporter.java	line 75	1188224978203	132721
The method getTextFileBuffer(IPath) from the type ITextFileBufferManager is deprecated	org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders	ErrorReporter.java	line 72	1188224978203	132720

Comment 1 Fabio Mancinelli

2007-08-27 16:56:08 EDT

Created attachment 77071 [details]
A patch to fix the bug

Just added LocationKind.NORMALIZE to method calls.

I used LocationKind.NORMALIZE after looking at org.eclipse.core.internal.filebuffers.TextFileBufferManager.connect/disconnect/getTextFileBuffer

TextFileBufferManager, in fact, is the base object returned by FileBuffers.getTextFileBufferManager() and that is used in the lines mentioned in the bug report.

Deprecated method calls are equivalent to calling the suggested method with the LocationKind.NORMALIZE parameter

Fabio

Comment 2 Brian Bauman

2007-08-27 17:36:08 EDT

Chris, can you take a look at this one the same time you look at 201306.  Should take just a minute.

Comment 3 Chris Aniszczyk

2007-08-27 19:16:19 EDT

committed to HEAD.

Thanks Fabio! :)

Comment 4 Chris Aniszczyk

2007-08-27 19:16:22 EDT

Created attachment 77081 [details]
mylyn/context/zip