Summary: | Toolbar buttons for next/prev have no effect | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Nick Edgar <n.a.edgar> | ||||
Component: | Compare | Assignee: | Dirk Baeumer <dirk_baeumer> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | critical | ||||||
Priority: | P1 | CC: | dean.t.roberts, dirk_baeumer, Kevin_McGuire | ||||
Version: | 2.0 | ||||||
Target Milestone: | 2.0 F4 | ||||||
Hardware: | PC | ||||||
OS: | Windows 2000 | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Nick Edgar
2002-06-12 21:27:17 EDT
Verified that they don't work. However next/prev from the Navigate menu and the corresponding short cuts work. Have to investigate why this is so different. Candiadte for F4 The short cut and the navigate menu only works in the compare editor, they don't work in the synchronize view. *** Bug 19592 has been marked as a duplicate of this bug. *** consequence if not fixed: serious usability issue, non working functionality. The fact that the short cuts don't work in the synchronize view looks like the Synchronize view doesn't retarget the action. CCed Kevin. The SyncView problem is separate and there is a fix see 19942. The problem in the CompareEditor is that the activate editor is not propagated to the ToolBar actions. This was introduced in F3. The fix is in CompareEditorContributor.setActivePart. Fix is trivial and ready to be released. public void setActiveEditor(IEditorPart targetEditor) { //... if (fActiveEditorPart != null) { IEditorInput input= fActiveEditorPart.getEditorInput(); if (input instanceof CompareEditorInput) { CompareEditorInput compareInput= (CompareEditorInput) input; fNext.setCompareEditorInput(compareInput); fPrevious.setCompareEditorInput(compareInput); // fix for 20105 fToolbarNext.setCompareEditorInput (compareInput); fToolbarPrevious.setCompareEditorInput (compareInput); } } Enclosed the path that fixes the problem Index: CompareEditorContributor.java =================================================================== RCS file: /home/eclipse/org.eclipse.compare/compare/org/eclipse/compare/internal/Com pareEditorContributor.java,v retrieving revision 1.9 diff -u -r1.9 CompareEditorContributor.java --- CompareEditorContributor.java 6 Jun 2002 10:56:55 -0000 1.9 +++ CompareEditorContributor.java 17 Jun 2002 09:45:23 -0000 @@ -64,6 +64,10 @@ CompareEditorInput compareInput= (CompareEditorInput) input; fNext.setCompareEditorInput(compareInput); fPrevious.setCompareEditorInput(compareInput); + // Begin fix http://bugs.eclipse.org/bugs/show_bug.cgi?id=20105 + fToolbarNext.setCompareEditorInput (compareInput); + fToolbarPrevious.setCompareEditorInput (compareInput); + // End fix http://bugs.eclipse.org/bugs/show_bug.cgi?id=20105 } } Created attachment 1447 [details]
Patch that fixes the problem
First review by Daniel Megert Second review by Martin Aeschlimann |