Summary: | [search] Camel Case match prefix insensitive although spec says prefix sensitive | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> |
Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | jerome_lanneluc, markus.kell.r |
Version: | 3.4 | ||
Target Milestone: | 3.4 M2 | ||
Hardware: | PC | ||
OS: | All | ||
Whiteboard: | |||
Bug Depends on: | 124624 | ||
Bug Blocks: |
Description
Frederic Fusier
2007-08-17 12:44:25 EDT
Markus, The patch for bug 124624, I'm currently working on, already fixes this issue (this is in fact how I discovered this wrong behavior). But change this behavior will have an impact on backward compatibility usage, as enter 'NULL' in Open Type dialog will no longer return any match... So, we need to synchronize with you if you want to keep the current behavior in Open Type dialog and then add SearchPattern.R_PREFIX_MATCH to accept insensitive prefix (as I plan to explain in the new javadoc comment of R_CAMELCASE_MATCH - see bug 124624 comment 17). Of course, if you think that current behavior is not good and only case sensitive prefix should match, then you'll have nothing to change... Just let me know, thanks Decision on this point was made: current SearchPattern#R_CAMELCASE_MATCH constant will still behave as it usually did in 3.3. The javadoc comment will be updated to describe the real behavior of SearchEngine while using this constant. However, as a new constant was necessary for bug 124624, we'll depreciate SearchPattern#R_CAMELCASE_MATCH and will advice users to only use the new one (SearchPattern#R_CAMEL_CASE_MATCH). We need to do it as previous SearchPattern#R_CAMELCASE_MATCH had unsolvable design issues... Of course this depreciated constant will always be accepted by SearchEngine and will be equivalent to the combination of SearchPattern#R_CAMELCASE_MATCH and SearchPattern#R_PREFIX_MATCH Patch released for 3.4M2 in HEAD stream (see patch attached to bug 124624). (In reply to comment #3) Verified for 3.4 M2 using build I20070917-0010. |