Bug 199169

Summary: The plugin.xml structure merge viewer does not show document root
Product: [Eclipse Project] PDE Reporter: Adam Archer <agarcher>
Component: UIAssignee: Adam Archer <agarcher>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: baumanbr
Version: 3.4Keywords: contributed
Target Milestone: 3.4 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Adam Archer CLA 2007-08-07 17:15:54 EDT
Using the latest pde.ui code from HEAD:

- Make at least one change to a plugin.xml file checked out from the repository.
- Synchronize the project containing the plugin.xml with HEAD.
- Double-click on the plugin.xml. You will see a structural compare and a content compare.
- Double-click on a specific change from the structure compare area. The content compare zooms to show just the affected range of the document. Excellent.

BUG: Now that the document is zoomed to the change, there is no way to view the entire document again since we do not have a root element in the tree.

If you look at the Java merge viewer, for instance, the root element is the Compilation Unit which allows the user to reset the view back to the entire document.
Comment 1 Brian Bauman CLA 2007-08-07 17:27:39 EDT
Adam to investigate
Comment 2 Wassim Melhem CLA 2007-08-07 17:28:16 EDT
Yes, I had noticed that too, but forgot to report it.
Comment 3 Adam Archer CLA 2007-08-08 11:41:30 EDT
This bug is present in the manifest structure compare as well.
Comment 4 Adam Archer CLA 2007-08-09 10:30:25 EDT
Created attachment 75768 [details]
patch

Adds a root node to the manifest.mf compare and the plugin.xml/fragment.xml compare.
Comment 5 Brian Bauman CLA 2007-08-10 11:46:34 EDT
Looks good to me.  Committed to HEAD.