Bugzilla – Full Text Bug Listing
| Summary: | [Viewers] Using FocusCellOwnerDrawHighlighter with OwnerDrawLabelProvider | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | charles Prevot <charlesantispam-eclipse> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bokowski, charlesantispam-eclipse, dany.eudes, pavel.sklenak, tom.schindl |
| Version: | 3.3 | Keywords: | contributed |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows NT | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
charles Prevot
Created attachment 74677 [details]
A solution to make them work together
Marking for investigation in M2. Moving to M3. Two comments: if ((event.detail & SWT.SELECTED) > 0) return; When doing bitwise operations, it is safer to do a '!= 0' comparison. Depending on the value of SWT.SELECTED, the result of the bitwise and operation might be negative. Color colorByColumns = new Color(Display.getCurrent(), color.getRed(), event.index*255/_tableViewer.getTable().getColumnCount(), color.getBlue()); You are creating color objects in paint() without disposing of them at some later point. This will leak resources and may lead to a crash if you keep the program running for long enough. That aside, thanks a lot for the contribution. Do you think something like this should become part of JFace itself, or would it be enough to add another snippet to our collection? (In reply to comment #4) > Two comments: > > if ((event.detail & SWT.SELECTED) > 0) > return; > > When doing bitwise operations, it is safer to do a '!= 0' comparison. Depending > on the value of SWT.SELECTED, the result of the bitwise and operation might be > negative. OK, thank you for helping me debugging my code ;) > > Color colorByColumns = new Color(Display.getCurrent(), > color.getRed(), event.index*255/_tableViewer.getTable().getColumnCount(), > color.getBlue()); > > You are creating color objects in paint() without disposing of them at some > later point. This will leak resources and may lead to a crash if you keep the > program running for long enough. I thought a Color was like other Java objects managed by the garbage collector. Considering your comment, I am surely wrong. Do you have a suggestion where to put the dispose call ? > > That aside, thanks a lot for the contribution. Do you think something like > this should become part of JFace itself, or would it be enough to add another > snippet to our collection? In fact I had to write that code because of the display bugs I had in vista with the table viewer. I need to have a table of empty cells (ie. without text nor image) identified by their background color. But, on Vista, there is a highlighting feature (when you have the mouse over a row) that erases the Background color of a cell (provided by a color provider). Thats why I had to work with ownerdraw. I think a single snippet for this particular case is a good solution, but having a way in JFace (or SWT) to manage this highlighting feature would be interesting too. (In reply to comment #5) > I thought a Color was like other Java objects managed by the garbage collector. > Considering your comment, I am surely wrong. Do you have a suggestion where to > put the dispose call ? If the color is different for each table cell, a possible solution would be to maintain a list of color objects allocated for a table item, for example by calling TableItem.setData(String, colorArray). Then, hook a dispose listener on each item so that you can dispose of the color objects from the widgetDisposed() method. I'm removing the target milestone because it is too late to put this in M3, but I'd be happy to add this snippet to our collection when it is ready. FocusCellOwnerDrawHighlighter doesn't support SWT.MULTI style. It seems only possible solution is to define TableCursor but using TableCursor together with OwnerDrawLabelProvider seems as crude solution. Created attachment 90165 [details]
Proposal of modified FocusCellOwnerDrawHighlighter
I tried to detect selected cell by arrows. I modified FocusCellOwnerDrawHighlighter to enable multiselection, and cell selection by keys
(In reply to comment #8) > Created an attachment (id=90165) [details] > Proposal of modified FocusCellOwnerDrawHighlighter > > I tried to detect selected cell by arrows. I modified > FocusCellOwnerDrawHighlighter to enable multiselection, and cell selection by > keys > Am I looking at the wrong place but I can't see a difference between the current FocusCellOwnerDrawHighlighter and the one you attached. Please provide your changes as a patch-file against current JFace-HEAD. Created attachment 90189 [details] patch file against JFace-HEAD (In reply to comment #9) I adjusted changes to current head revision (previously was M20070910-0800b). Method's names are not appropriate after swiching markFocusedCell/removeSelectionInformation logic so it needs somehow also adjust it... Tom, can you take this one? I don't have time to investigate. Created attachment 100632 [details]
FocusCellOwnerDrawBorderHighlighter
I modified FocusCellOwnerDrawHighlighter to FocusCellOwnerDrawBorderHighlighter. Reason is that I need support for SWT.MULTI style. Also there is event sent when selected cell is changed (typically by using arrows)
Created attachment 100633 [details]
Snippet for demonstrating FocusCellOwnerDrawBorderHighlighter
multi change because of intenion of stepping back as platform-ui committer This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |