Bug 197484

Summary: SystemView does not provide IContextObject for filter levels deeper than 1
Product: [Tools] Target Management Reporter: Tobias Schwarz <tobias.schwarz>
Component: RSEAssignee: Martin Oberhuber <mober.at+eclipse>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: major    
Priority: P1 CC: martin.gutschelhofer, uwe.st
Version: 2.0Keywords: contributed
Target Milestone: 2.0.1Flags: mober.at+eclipse: pmc_approved+
dmcknigh: review+
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 197550    
Attachments:
Description Flags
provide IContextObject for all children mober.at+eclipse: iplog+

Description Tobias Schwarz CLA 2007-07-23 09:46:35 EDT
Build ID: rse 2.0

in our own subsystem, when refreshing a filter with folders, the content of the folders isn't filtered.
getChildren() of the element adapter doesn't get a IContextObject.
the context is only provided for the first filter level (in our subsystem the folder).

i located the problem inside SystemView.doOurInternalRefresh() and internalRSERefreshStruct(), where the input for the refresh of the children wasn't translated to an IContextObject.

i attach a patch, that solves this problem.
Comment 1 Tobias Schwarz CLA 2007-07-23 10:15:29 EDT
Created attachment 74357 [details]
provide IContextObject for all children

Legal Message:
I, Tobias Schwarz, declare that I developed attached code from scratch, without
referencing any 3rd party materials except material licensed under the EPL. {I
am authorized by my employer to make this contribution under the EPL.}
Comment 2 Martin Oberhuber CLA 2007-07-23 10:27:29 EDT
Patch looks good to me.
I committed it since we urgently need this:
[197484] Fix for SystemView to provide ContextObject for queries on all levels

DaveM can you please review it, thanks.
Comment 3 David McKnight CLA 2007-07-23 10:42:25 EDT
Looks okay to me.
Comment 4 Martin Oberhuber CLA 2007-07-23 11:02:32 EDT
Released for I20070723