Summary: | Formatter expands @ in annotation in javadoc, creating invalid tag | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Matt McCutchen <hashproduct+eclipse> | ||||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | david_audel, jerome_lanneluc | ||||||
Version: | 3.3 | Keywords: | contributed | ||||||
Target Milestone: | 3.3.1 | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Whiteboard: | |||||||||
Bug Depends on: | 198153 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Matt McCutchen
2007-07-19 12:36:49 EDT
Oops, I forgot a step: 1/2. Go to Window -> Preferences -> Java -> Compiler -> Javadoc and ensure that "Malformed Javadoc comments" is set to at least Warning. Created attachment 74826 [details]
Fix
This patch fixes the bug by changing Java2HTMLEntityReader to translate a @ back to a @ when it is the first thing on a line.
I can't recommend the use of @ until bug 198153 is also fixed because the formatter adds another space before the @ each time you format the code. Created attachment 74955 [details] Add regression test This patch applies on top of my regression test for bug 198153. Released for 3.4M1. Added regression test in org.eclipse.jdt.core.tests.formatter.comment.JavaDocTestCase#test197169 Thanks for the contribution. Verified for 3.4M1 using build I20070806-1800. Jérôme, The fix for this bug is also required to be backported for 3.3.1 in order to properly backport bug 109636. +1 for 3.3.1 ? +1 for backporting to 3.3.1 Reopen for 3.3.1. Released for 3.3.1. Added regression test in org.eclipse.jdt.core.tests.formatter.comment.JavaDocTestCase#test197169 Verified for 3.3.1 using build M20070831-2000. |