Summary: | hover help stops working after mousing over end of file | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Amy Wu <for.work.things> | ||||
Component: | UI | Assignee: | Kai-Uwe Maetzel <kai-uwe_maetzel> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P2 | CC: | daniel_megert, david_williams, erich_gamma, paulacox, sja.eclipse, turnham | ||||
Version: | 2.0 | ||||||
Target Milestone: | 2.0.1 | ||||||
Hardware: | PC | ||||||
OS: | Windows 2000 | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Amy Wu
2002-06-07 17:42:03 EDT
can reproduce. JUnit setup 1) create CU T.java package junit.framework; public class T { TestCase t; } 2) move the mouse cursor after the close brace of the class as described below. Reviewed by Erich. I added the hover help capability to my own custom-made source editor/viewer. In general, whenever I hover over any whitespace, not just the end of the file, I noticed hoverhelp stopped working. (My hover help used to work before F2) Will this fix probably fix that problem as well? If so, could you describe the fix and is this a fix that can be made into a patch for F2? (I would like to stay on the F2 base and provide a temporary patch till moving up to F3) Thanks. Verified. TB, but leaving as resolved fixed for further discussion Nevermind, I'm going to move up to F3, and it looks like my hover help problems were fixed with this fix. Thanks. Just moved up to GM1 build, and this bug is back again! Within F3, bug has been "resolved" by an improper implementation that has been fixed for F4. This was (almost) undetectable. Thus, the problem is back. I don't think the fix will make it into 2.0 Created attachment 1597 [details]
patch for TextViewerHoverManager
i wanted to add another case where hover help fails (that is related to this defect/fix) there was a bugzilla defect #19719 stating that hover help stopped working after you turned it on then off. This problem also came back. If you turn hoverhelp off, hover over text in the file, then turn hoverhelp back on, hoverhelp still doesn't work. I had originally discovered this problem because my ITextHover stopped working every time I hovered over whitespace, not just at the end of the file, like Java's hover, so this defect was more detectable for me. Since I can only build off of eclipse's stable builds, I cannot put in your patch for TextViewerHoverManager. I have, however, come up with a workaround. I noticed that hoverhelp would stop working when I returned null in ITextHover.getHoverRegion(viewer, offset), which is what I return when hovering over whitespace. As a workaround, rather than returning null, I will instead return a region where offset=offset & length=0 in ITextHover.getHoverRegion(..) Questions: 1. Does my workaround sound good? 2. I am concerned about decreased performance due to the call to TextHoverManager.computeArea(..) after checking ITextHover.getHoverRegion(..) ! = null. Is there some better solution/workaround? 3. Should I open a new defect or continue discussion in this defect since it sounds like the fix for this defect will be different than it was before? 4. Is it still very likely that your fix will not make it into v2.0? Thanks. Patch applied in the 2.0.1 and the 2.1 stream. verified on 2.0.1 build 20020821 |