Bug 194602

Summary:

Double Clicking on Folder sometimes expands wrong folder

Product:

[Tools] Target Management

Reporter:

Kevin Doyle <kjdoyle>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

CLOSED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

dmcknigh, kmunir

Version:

2.0

Keywords:

contributed

Target Milestone:

2.0.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Modified handleDoubleClick to use TreePath instead of element.	mober.at+eclipse: iplog+

Description Kevin Doyle

2007-06-27 09:17:32 EDT

If you create a filter on some folder that has subfolders then try double clicking on the folder in the filter and double clicking on the folder in Root/Drives filter, then only one of the folders will get expanded.  Double Clicking on one of them will expand the other.

Steps to Reproduce:
1. Create a filter on some folder that is not expanded.
2. Expand that folder.
3. Expand the filter.
4. Double Click on a folder in the filter.  It will expand the folder under your Root/Drives filter.

If that didn't work to reproduce it, try double clicking on the folder not in the filter and see if it expands the filter's folder.  

-----------Enter bugs above this line-----------
TM 2.0RC4 Testing
installation : eclipse-SDK-3.3RC4
RSE install  : RSE 2.0 RC4
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------

Comment 1 Kevin Doyle

2007-06-27 10:45:58 EDT

Created attachment 72606 [details]
Modified handleDoubleClick to use TreePath instead of element.

Changed SystemView.handleDoubleClick so it does expand/collapse based on the elements TreePath instead of the element itself.  This way the proper TreeItem is expanded/collapsed.

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.

Comment 2 David McKnight

2007-06-29 10:26:50 EDT

I've applied the patch to cvs.

Comment 3 Martin Oberhuber

2007-06-29 10:32:08 EDT

Thanks Dave.

As a little additional bookkeeping item, can you please do the following in the future: When committing a contributed patch to CVS (i.e. one with the "Legal Message:" somewhere), when you add it to the tm-log.csv, please add the keyword "contributed" on bugzilla.

This is an additional safeguard that the tm-log.cvs is correct, it allows making a query for all "contributed" bugzilla items and compare it against what we have in tm-log.csv.

Thanks!

Comment 4 Kevin Doyle

2007-07-05 11:38:44 EDT

Verified with driver I20070705-0600.