Bug 194338

Summary: [Min/Max] File | Close action incorrectly disabled after restoring views
Product: [Eclipse Project] Platform Reporter: Jeff Hardy <jefhardy>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: ASSIGNED --- QA Contact:
Severity: normal    
Priority: P3    
Version: 3.3   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Jeff Hardy CLA 2007-06-25 19:18:29 EDT 
Build ID: I20070608-1718  (3.3.0 RC4)

Steps To Reproduce:
1. Open an editor (I used a new workspace with a Hello World plugin project and opened the plugin editor).
2. Double-click a view in the lower-right pane (problems, javadoc, declaration, etc) to maximize the view.
3.  Use the "restore" button on the Package Explorer/Hierarchy view.
3.  The File | Close & Close All actions are disabled, despite there being an open editor.  Giving focus to the editor will re-enable the close actions.


More information:
While the view is maximized, clicking the Restore button on the "Editor Area" will result in the Close actions being enabled.
Comment 1 Eric Moffatt CLA 2007-06-27 10:10:56 EDT 
The commands being disabled was the result of the editor area being moved to the trim on the view's max. 

After a minimize the active part is updated to ensure that there's something active in the presentation. If the editor was the previously active part in the scenario then the commands go disabled when the ViewStack gets maximized (which uses setMinimize calls), otherwise they're still active after the maximize.

However, even in the case where they're active after the maximize (i.e. click on editor, click on Outline, then maximize) using the 'Restore' button -still- causes the commands to deactivate....Hmmm, gotta check the unZoom/setMinimize handling.

Hint to self: put a conditional breakpoint in Command#fireCommandChanged(*) ... the command id is 'org.eclipse.ui.file.closeAll'
Comment 2 Eric Moffatt CLA 2007-08-22 13:19:17 EDT 
Moving to 3.4 since the issue is easily worked around and the code is complex.
Comment 3 Eclipse Webmaster CLA 2019-09-06 16:14:59 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.