Bug 193947

Summary: Do not set layout data for search page in SearchDialog.createPageControl
Product: [Eclipse Project] Platform Reporter: Benno Baumgartner <benno.baumgartner>
Component: SearchAssignee: Platform-Search-Inbox <platform-search-inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3    
Version: 3.3   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Benno Baumgartner CLA 2007-06-22 06:25:09 EDT
N20070621-0010

Please remove the line 679
page.getControl().setLayoutData(new GridData(SWT.FILL, SWT.BEGINNING, true, false));

in org.eclipse.search.internal.ui.SearchDialog.createPageControl(Composite, SearchPageDescriptor)

Let the page decide which layout is best for it. I want to have a page where the scope selection part is always at the bottom, giving me space to use on the page center (controls are added dynamically to the page).
Comment 1 Martin Aeschlimann CLA 2007-06-22 06:41:27 EDT
The search page can't know what layout the container uses. We would have to spec this. Of course we could add this as a hidden feature, that wen the control already has a grid layout set, we keep this. But I'm not sure if this wouldn't break existing implementations that happen to have added a buggy layout data.
Comment 2 Benno Baumgartner CLA 2007-06-22 08:47:04 EDT
(In reply to comment #1)
> The search page can't know what layout the container uses. 

That's why it should not make assumptions about what the container needs.

> We would have to
> spec this. Of course we could add this as a hidden feature, that wen the
> control already has a grid layout set, we keep this. But I'm not sure if this
> wouldn't break existing implementations that happen to have added a buggy
> layout data.
> 

We could also add an optional attribute to org.eclipse.search.searchPages page extension, like grapExcessiveSpace true|false, with false as default

Of course changing the line to 
page.getControl().setLayoutData(new GridData(SWT.FILL, SWT.FILL, true,
true));

would work too, at least for me;-)
Comment 3 Eclipse Webmaster CLA 2019-09-06 16:06:22 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.