Bug 192278

Summary: [scratchpad] Delete Dialog appears twice when Deleting from Scratchpad
Product: [Tools] Target Management Reporter: Kevin Doyle <kjdoyle>
Component: RSEAssignee: Kevin Doyle <kjdoyle>
Status: CLOSED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh, kmunir
Version: 2.0Keywords: contributed
Target Milestone: 2.0.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Removes handleKeyPressed() from SystemScratchpadView mober.at+eclipse: iplog+

Description Kevin Doyle CLA 2007-06-12 15:56:30 EDT 
If you delete a file from the Scratchpad the delete dialog will appear twice.

Steps to reproduce:
1. Drag a file into the scratchpad.
2. Click on that file in the scratchpad.
3. Press Delete Key.
4. First dialog appears.  Click Delete.  Then second dialog appears.

-----------Enter bugs above this line-----------
TM 2.0RC2 Testing
installation : eclipse-SDK-3.3RC3
RSE install  : RSE 2.0 RC2
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 Kevin Doyle CLA 2007-06-12 16:27:21 EDT 
Created attachment 71086 [details]
Removes handleKeyPressed() from SystemScratchpadView

Patch removes handleKeyPressed(), as it is only used for the delete key which is already handled by the eclipse WorkbenchKeyboard.

Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
Comment 2 David McKnight CLA 2007-06-29 10:35:24 EDT 
The originaly key handling code was there because the workbenchkeyboard handling didn't used to work properly.  Now that it seems fine, we can get rid of that.  I've applied the patch to cvs.
Comment 3 Kevin Doyle CLA 2007-07-05 13:46:20 EDT 
Verified with I20070705-0600.