Summary: | [batch][compiler] help message for annotations processing should be improved | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Maxime Daniel <maxime_daniel> | ||||||||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||||||
Severity: | normal | ||||||||||||
Priority: | P3 | CC: | jerome_lanneluc, philippe_mulet | ||||||||||
Version: | 3.3 | ||||||||||||
Target Milestone: | 3.4 M1 | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | All | ||||||||||||
Whiteboard: | |||||||||||||
Attachments: |
|
Description
Maxime Daniel
2007-06-05 02:30:44 EDT
Created attachment 70176 [details]
Proposed fix
Created attachment 70245 [details]
updated patch
Here's my version of the proposed patch; in addition to correcting typos I tried to clarify the text a bit.
Created attachment 70251 [details]
Updated patch + regression tests
Walter's patch + corresponding regression tests updated
All tests passed with this patch. Closing as WONTFIX since this won't go in for 3.3 and the whole print usage should be reorganized for 3.4. Even if print usage is rewritten, we should not loose the suggestions included in this bug. Updated batch compiler tests also passed on Linux. If this doesn't make it for 3.3, I'll release it for 3.3.1. It doesn't affect translations (in fact actual code might make the translation more difficult since some sentences are not very clear) since it is only a rephrasing of the English sentences. The meaning is similar. Created attachment 73337 [details]
Proposed fix + regression test
Same patch, but without the change in the print usage for the warnings. I thought it was over the 80 character limit, but it just fits in. So no need for this change.
Only the rewording of the annotation processing help is required.
Released for 3.4M1. Updated the regression tests inside BatchCompilerTests. Might want to backport to 3.3.1 in order to clarify the annotation processing options. Verified for 3.4M1 using build I20070806-1800. |