Bug 19013

Summary: backgronud color: is it honored?
Product: [Eclipse Project] Platform Reporter: Adam Kiezun <akiezun>
Component: CompareAssignee: Andre Weinand <andre_weinand>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 2.0   
Target Milestone: 2.0 F3   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Bug Depends on:    
Bug Blocks: 19216    

Description Adam Kiezun CLA 2002-06-04 08:47:01 EDT
F2
i set the color to yellow for testing but have been unsuccesful in seeing a 
compare viewer use this color for background
(even the preview does not use it)
Comment 1 Andre Weinand CLA 2002-06-04 08:57:55 EDT
Yes, correct. I'm using the background color of the Java Editor.
Should I remove the Compare editor's preference background color field
or should I support a my own background color?
Comment 2 Adam Kiezun CLA 2002-06-04 15:50:03 EDT
i don't know, Andre, but the current state is confusing.
does the preference apply anywhere (text files probably)?
maybe make it more explicit that java compare uses java editor settings ?

not sure how important all that is - i do not change the backround color 
normally, but some people do
Comment 3 Andre Weinand CLA 2002-06-05 09:55:01 EDT
There are two cases to consider:
- the background color for the Java compare viewer
- the background color for the generic text compare viewer

For the Java compare viewer the background color preference is taken from the 
Java Editor preferences.

Since there is no background color preference for generic text editors I can 
not get the background color for the generic text compare viewer from there.
However the foreground and background colors for the generic text editor can be 
adjusted via Control Panel/Display Properties/Appearance.

Therefore I will remove the Background color preference from the Compare 
preference page to avoid confusion.
Comment 4 Andre Weinand CLA 2002-06-06 06:25:53 EDT
fixed for 20020606
Removed the background color field from Compare preference page.
The Java Compare viewer uses the Java Editor colors,
the generic text compare viewer uses the system settings.

Fix reviewed by Dirk Baeumer
Comment 5 Dirk Baeumer CLA 2002-06-13 05:21:14 EDT
Verified. TB