Bug 18826

Summary: poor update manager download performance
Product: [Eclipse Project] Platform Reporter: Jim des Rivieres <jeem>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Christophe Elek <celek>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2    
Version: 2.0   
Target Milestone: 2.0.2   
Hardware: PC   
OS: All   
Whiteboard:

Description Jim des Rivieres CLA 2002-06-03 13:37:45 EDT
F2

The update manager takes a long time to download features.
This is especially noticeable when the update site is on the
machine's local disk, meaning that network speed is not a 
factor.

A quick look at the code shows some low-hanging fruit:
- Increase the size of the internal buffer used when copying files.
org.eclipse.update.core.Utilities.BUFFER_SIZE is current only 4KB
bytes; increasing it to something like 256KB will make it possible
to slurp files in large chunks.
- Use BufferedOutputSteams for writing files.
org.eclipse.update.core.FeatureContentProvider.asLocalReference
creates a FileOutputStream for making a local copy, and this
would likely benefit from being buffered.
Comment 1 Vlad Klicnik CLA 2002-06-04 13:19:57 EDT
F3 candidate
Comment 2 Christophe Elek CLA 2002-09-23 07:37:21 EDT
change in 2.0.2 stream
Comment 3 Christophe Elek CLA 2002-10-07 08:33:24 EDT
Change doesn't seem to improve speed at first glance.
need to profile it but simple date outuput shows it may even be slower...

Leave changed code. need to profile.
Comment 4 Dejan Glozic CLA 2002-10-21 11:07:37 EDT
suggestion implemented. Further performance improvements should be done under a 
different defect.