Summary: | CompletionTestsRequestor2.getReversedResults has incorrect comparator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Alexey A. Petrenko <alexey.a.petrenko> | ||||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | kent_johnson | ||||||
Version: | 3.3 | Flags: | kent_johnson:
review+
|
||||||
Target Milestone: | 3.3 RC1 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Alexey A. Petrenko
2007-05-16 06:20:02 EDT
Created attachment 67444 [details]
Proposed fix
I'll run all the tests with this patch.
Olivier, thanks for the patch. I would change the initial null checks in the following way: === cut === if (o1 == o2) return 0; if (o1 == null) return 1; if (o2 == null) return -1; === cut === It looks more clear and first check could avoid all other comparisons for non-null cases. What do you think? Yes, even better. I'll release it later today for 6pm build. Created attachment 67468 [details]
Better patch
Kent, please review. Thank you. Released for 3.3RC1. No regression test. Alexey, could you please put a note to say this is fixed with next integration build? Yes, sure. I'll test it tomorrow. It's almost night here :) Thanks, guys, for so quick response. Alexey, once I have your confirmation that it works now I'll close it as verified. The patch works. Thanks again. |