Summary: | [StyledText] Change StyledTextContent offsets to long | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Andrew Brampton <andrew> |
Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | ericwill, pestatije, Silenio_Quarti, steve_northover |
Version: | 3.3 | Keywords: | triaged |
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Andrew Brampton
2007-05-12 09:32:13 EDT
Not sure we can make this change without breaking binary compatibility and/or API. (In reply to comment #1) > Not sure we can make this change without breaking binary compatibility and/or > API. > I don't know eclipses policies, but other open source projects would make this kind of API change between major revisions. I see 3.3 is coming up, so maybe this change could be made in 3.4? Thanks This is not going in for Eclipse 3.3 (we are too close to the release date to try any major change). Also, before changing this we really need to know what is the impact in performance, will StyledText scale well to handle such huge files ? Its been over a year, and I had honestly forgot about this feature request. I just thought I'd leave a new comment to see what the current state of things are, and if this can be reconsidered for the next major version of Eclipse. Felipe mentioned he would like to know if "StyledText scale well to handle such huge files". When I have some free time I will make the required changes so that StyleText uses long offsets, and return some benchmark results. thanks Andrew I think this would be very useful. Even if we cannot break the API for the moment, additional equivalent methods with long offsets could be added. The impact on performance will not be affected by the change from int to longs. It is surely related to file length, but if you can deal with a file of 1.9Gbytes, why not with a file of 2.1Gbytes? Your bug has been moved to triage, visit http://www.eclipse.org/swt/triage.php for more info. No response in awhile, not sure if this bug is still valid. I'll leave it open since it's an enhancement. |