Bug 184126

Description Tao Weng 2007-04-25 17:01:04 EDT

Build ID: M20070212-1330

Steps To Reproduce:
I'm having refreshing issue with property view. After debugging a little bit, I found out that it was caused by doGetValue method of ExtendedComboBoxCellEditor.

Originally, the method looks like:
public Object doGetValue() {
    	    if (list != null && selection >= 0) {
    	        // Get the index into the list via this call to super.

    	        return selection < list.size() && selection >= 0 ? list.get(selection) : null;
    	    }
    	
    	    if (getStyle() == SWT.READ_ONLY && selection >= 0) 
                return new Integer(selection);
    	    
            if(selection < 0)
                return comboBox.getText();
            
            return comboBox.getItem(selection);
    	}


However, I feel that it should look like the following.
selection value has to be up-to-date in order to retrieve the correct value of the combo box. As such, 
selection = comboBox.getSelectionIndex(); should be called at the beginning of the method. Please fix this one as soon as possible cause it causes severe refreshing issue to Property pages.


public Object doGetValue() {
    	selection = comboBox.getSelectionIndex();
    	    if (list != null && selection >= 0) {
    	        // Get the index into the list via this call to super.

    	        return selection < list.size() && selection >= 0 ? list.get(selection) : null;
    	    }
    	
    	    if (getStyle() == SWT.READ_ONLY && selection >= 0) 
                return new Integer(selection);
    	    
            if(selection < 0)
                return comboBox.getText();
            
            return comboBox.getItem(selection);
    	}

More information: