Bug 183916

Summary:	MethodVerifier#reportIncompatibleReturnTypeError is a misnomer
Product:	[Eclipse Project] JDT	Reporter:	Maxime Daniel <maxime_daniel>
Component:	Core	Assignee:	Maxime Daniel <maxime_daniel>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	kent_johnson
Version:	3.3
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Maxime Daniel

2007-04-25 00:43:59 EDT

Code based, circa v_750.
See also bug 180789.
reportIncompatibleReturnTypeError reports an incompatible return type error... or not, depending on the considered return types being strictly incompatible or convertible by an unchecked conversion. I would rather document that areReturnTypesCompatible returns true iff return types are strictly compatible and introduce a new method, could be areReturnTypesConvertible, that would enable the caller to decide whether an error or an unchecked warning should be issued.
Note: while I have thought about areReturnTypesCompatible returning a tristate (COMPATIBLE, INCOMPATIBLE, CONVERTIBLE), it would cause more grief to callers within JDT Core, and probably hamper performances as well.

Comment 1 Maxime Daniel

2007-04-25 00:44:52 EDT

Will tackle this post 3.3.

Comment 2 Maxime Daniel

2007-09-07 06:10:43 EDT

Kent, what do you think of this one?

Comment 3 Kent Johnson

2007-09-07 10:18:24 EDT

Its a private method name in a non-public type that is overridden by a subclass which chooses to do something different.

I see no reason to spend time renaming methods in this case.

Comment 4 Maxime Daniel

2007-09-07 10:30:52 EDT

Closing as WONTFIX.