Bug 18370

Summary:	get rid of all fragment.properties in core fragments
Product:	[Eclipse Project] Platform	Reporter:	Jim des Rivieres <jeem>
Component:	Resources	Assignee:	DJ Houghton <dj.houghton>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P1	CC:	Darin_Swanson
Version:	2.0
Target Milestone:	2.0 F3
Hardware:	PC
OS:	All
Whiteboard:

Description Jim des Rivieres

2002-05-30 16:10:01 EDT

All externalized strings for a fragment.xml (typically the fragment name
and the provider name) must be placed in the plugin.properties file (!) of the 
corresponding plug-in.

There is no such thing as a fragment.properties file.

Here is an example that gives the general idea of it should look:

in the org.eclipse.foo.win32 fragment
   fragment.xml  
       <fragment
          id="org.eclipse.foo.win32"
          name="%win32FragmentName"
          provider-name="%providerName"
          version="2.0.0"
          plugin-id="org.eclipse.foo"
          plugin-version="2.0.0" /> 

in the org.eclipse.foo.linux fragment
   fragment.xml  
       <fragment
          id="org.eclipse.foo.linux"
          name="%linuxFragmentName"
          provider-name="%providerName"
          version="2.0.0"
          plugin-id="org.eclipse.foo"
          plugin-version="2.0.0" /> 

in the org.eclipse.foo plug-in
   plugin.xml  
      <plugin
          id="org.eclipse.foo"
          name="%pluginName"
          provider-name="%providerName"
          version="2.0.0" />
   plugin.properties
      pluginName=Foo
      providerName=Eclipse.org
      win32FragmentName=Foo for Windows
      linuxFragmentName=Foo for Linux

Comment 1 DJ Houghton

2002-05-30 16:19:00 EDT

How is this going to work for the nl fragements which will be produced by 
RelEng? 

I presume that the fragment.xml files in them will just have the strings hard-
coded in them?

Comment 2 Jim des Rivieres

2002-05-30 18:15:50 EDT

The initial blurb is incorrect.  Here is a revised body:

There is no such thing as a fragment.properties file.
fragment.xml files do not have externalized strings.
The fragment name and provider name should be included in the fragment.xml.

E.g.,
   fragment.xml  
       <fragment
          id="org.eclipse.foo.win32"
          name="Foo for Windows"
          provider-name="Eclipse.org"
          version="2.0.0"
          plugin-id="org.eclipse.foo"
          plugin-version="2.0.0" />

Comment 3 DJ Houghton

2002-06-01 09:42:35 EDT

This one slipped through the cracks for build F2.
Add to list to consider for next build.

Comment 4 Jim des Rivieres

2002-06-03 15:06:31 EDT

We have decided to go with the first approach proposed: put the externalized
string into "plugin.properties."

Must fix for fix pass 2.

Comment 5 DJ Houghton

2002-06-03 15:50:41 EDT

*** Bug 18874 has been marked as a duplicate of this bug. ***

Comment 6 DJ Houghton

2002-06-10 16:07:42 EDT

Fixed. Reviewed. Released.