Summary: | [search] OutOfMemoryError during rename refactoring | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | John Arthorne <john.arthorne> | ||||||
Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | jerome_lanneluc | ||||||
Version: | 3.3 | ||||||||
Target Milestone: | 3.3 M7 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows Vista | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
John Arthorne
2007-04-18 16:56:15 EDT
How much memory on VM command line ? (-Xmx) Jerome, could we imagine getting information from Java Model (getChildren()) without populating it in this peculiar case? We could indeed use NameLookup#findPackageFragments(String, boolean) instead. No VM arguments. I have never found a need for them on IBM VMs. Created attachment 64600 [details]
Proposed patch
FSWST#testPackageDeclarations() performance test gives following results: Patch: 4.8ms (+/- 2,3ms) HEAD: 2062.4ms (+/-13,3ms) As with the patch time is under 100ms, I iterated it 20 times and get folllowing results: Patch x 20: 67.2ms (+/- 2,3ms) This makes an improvement of 99.8% :-)) Jerome, can you have a look on this patch please? Thanks Created attachment 64696 [details]
New proposed patch
Better patch as the indexOf on name is outside the loop in NameLookup.findPackageFragments(...) method. Also, take into account patternMatch parameter even if partialMatch is false which was not the case in previous patch.
Also added javadoc comment on this method.
Patch looks good (watch out the testONLY_ renaming :-) ) Patch released for 3.3 M7 in HEAD stream (without the ONLY_ in test name). Consider this problem fixed as we do no longer populate the Java Model. John, please give it a try with today's integration build and let us know if it's OK for you, thanks Search package declaration shows a gain between 96.7% and 100% => consider as verified for 3.3 M7 using perf results of I20070424-0930 |