Bug 181393

Summary: DefaultASTVisitor doesn't override all methods
Product: [Eclipse Project] JDT Reporter: Jerome Lanneluc <jerome_lanneluc>
Component: CoreAssignee: Jerome Lanneluc <jerome_lanneluc>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: marcelop
Version: 3.3   
Target Milestone: 3.3 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed fix none

Description Jerome Lanneluc CLA 2007-04-06 06:53:58 EDT 
I20070403

DefaultASTVisitor doesn't override all methods (e.g. it doesn't override visit(MarkerAnnotation). As a consequence, visitNode(ASTNode) and endVisitNode(ASTNode) are not called for all nodes in the AST.
Comment 1 Jerome Lanneluc CLA 2007-04-13 11:21:28 EDT 
Created attachment 63764 [details]
Proposed fix

Override all methods but visit(Modifier) and endVisit(Modifier) as we don't want to associate a comment with a modifier (ASTRewritingMethodDeclTest#testMethodReturnTypeChange2AST3() would fail).
Comment 2 Jerome Lanneluc CLA 2007-04-13 11:40:42 EDT 
*** Bug 182338 has been marked as a duplicate of this bug. ***
Comment 3 Jerome Lanneluc CLA 2007-04-13 12:35:50 EDT 
Fix released for 3.3M7 in HEAD.
Comment 4 Eric Jodet CLA 2007-04-27 06:29:48 EDT 
Verified for 3.3 M7 using build I20070427-0010