Summary: | Need a method to add extension models to gmfgen model | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Modeling] GMF-Tooling (ARCHIVED) | Reporter: | Richard Gronback <richard.gronback> | ||||||||
Component: | Core | Assignee: | Anna Karjakina <akarjakina> | ||||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||||
Severity: | normal | ||||||||||
Priority: | P1 | CC: | tikhomirov.artem | ||||||||
Version: | 2.0 | Keywords: | contributed | ||||||||
Target Milestone: | 2.0 | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Whiteboard: | |||||||||||
Attachments: |
|
Description
Richard Gronback
2007-04-05 08:42:23 EDT
Related bug #181844 As a first try, I'd stick to a separate action (registered against .gmfgen), which pops up a dialog to select an EMF model (.ecore), asks for metaclass to instantiate and adds new eObject instance to the eResource.contents. Created attachment 63889 [details]
"Add extension model..." context action with common-styled wizard added
Comment on attachment 63889 [details]
"Add extension model..." context action with common-styled wizard added
1. NPE on browse File System
java.lang.NullPointerException
at org.eclipse.emf.common.util.URI.createURIWithCache(URI.java:658)
at org.eclipse.emf.common.util.URI.createURI(URI.java:536)
at org.eclipse.gmf.internal.codegen.popup.actions.AddExtensionModelWizard$ModelImporterDetailPage.getModelLocationURI(AddExtensionModelWizard.java:221)
2. No need to allow for target encoding change.
3. Would be convenient to avoid two poorly populated pages.
Created attachment 64114 [details]
Action is completely rewritten
Action is completely rewritten to use standard wizard page from org.eclipse.gmf.bridge.ui module. Minor convinience tuning had to be added to org.eclipse.gmf.common as well.
Created attachment 64119 [details]
Terribly sorry, I have forgotten to include one more class to the previous patch!
reviewed, slightly refactored and committed. [target cleanup] 2.0 M7 was the original target milestone for this bug [GMF Restructure] Bug 319140 : product GMF and component UI was the original product and component for this bug |