Summary: | MonitorViewPage SelectionProvider | ||||||
---|---|---|---|---|---|---|---|
Product: | [Tools] Target Management | Reporter: | Andrey Asadchev <asadchev> | ||||
Component: | RSE | Assignee: | David McKnight <dmcknigh> | ||||
Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||
Severity: | normal | ||||||
Priority: | P3 | CC: | kjdoyle | ||||
Version: | 2.0 | Keywords: | contributed | ||||
Target Milestone: | 2.0.1 | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Andrey Asadchev
2007-03-15 12:32:20 EDT
To make this change will require API changes to the SystemMonitorViewPart. It will now have to implement ISelectionProvider and be a wrapper for the proper selection provider. It will also have to add a setActiveViewerSelectionProvider() method, so the proper selection provider for the active viewer is known. From: http://www.eclipse.org/articles/Article-WorkbenchSelections/article.html "Be aware that the part's site accepts a single selection provider only, which should be registered within the createPartControl() method only: getSite().setSelectionProvider(provider); Replacing the selection provider during the lifetime of the part is not properly supported by the workbench. If a part contains multiple viewers providing selections, like the "Java Hierarchy" view does, a intermediate ISelectionProvider implementation has to be provided that allows dynamically delegating to the currently active viewer within the part. " not important enough for 2.0, IMHO Created attachment 71516 [details]
Made the SystemMonitorViewPart a SelectionProvider that wraps the table viewers selection provider
Made the SystemMonitorViewPart a SelectionProvider that wraps the table viewers selection provider and updated the widgetSelected method so that it updated the wrapped provider when clicking on tabs in the Monitor.
Legal Message: I, Kevin Doyle, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this
contribution under the EPL.
I've applied the patch and committed it to cvs. Thanks Kevin! marking as fixed |