Bug 177279

Summary:	[model] potential redundant null test in JavaModelManager#containerIsInitializationInProgress
Product:	[Eclipse Project] JDT	Reporter:	Maxime Daniel <maxime_daniel>
Component:	Core	Assignee:	Frederic Fusier <frederic_fusier>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.3
Target Milestone:	3.3 M6
Hardware:	PC
OS:	All
Whiteboard:

Description Maxime Daniel

2007-03-14 03:05:37 EDT

Source based, around v_741.

Investiging bug 154984, I came accross line 462 of JavaModelManager that tests the result of a call to ThreadLocal#get against null. I believe this is superfluous given the documented behavior of that method.
(Please correct me if I am wrong.)

Comment 1 Maxime Daniel

2007-03-14 04:02:03 EDT

Sorry, ThreadLocal#get() may return null indeed. 'Creates and initializes the copy if this is the first time the thread has called this method' does not explicitly exclude the source of the copy to be null in fact - even if it is misleading.