Bug 175069

Summary:

[Preferences] ResourceInfoPage is not setting dialog font on all widgets

Product:

[Eclipse Project] Platform

Reporter:

Darin Swanson <Darin_Swanson>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, mmikas, remy.suen, Tod_Creasey

Version:

3.3

Keywords:

contributed, polish

Target Milestone:

3.5 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch to use Dialog's static applyDialogFont(Control) method.	remy.suen: iplog+

Description Darin Swanson

2007-02-21 21:04:07 EST

3.3M5

The text file encoding widgets are not using the dialog font.

Comment 1 Eric Moffatt

2007-02-23 15:52:14 EST

Note that bug 174812 may be related to this one...

Comment 2 Eric Moffatt

2007-02-26 15:44:29 EST

*** Bug 174812 has been marked as a duplicate of this bug. ***

Comment 3 Eric Moffatt

2007-02-26 15:50:06 EST

Please ensure that the scenario described in bug 174812 has been fixed.

Comment 4 Tod Creasey

2007-03-20 11:24:47 EDT

Bug 174812 is unrelated

Comment 5 Remy Suen

2008-07-31 20:20:26 EDT

Created attachment 108914 [details]
Patch to use Dialog's static applyDialogFont(Control) method.

I took the liberty of removing all those excessive setFont(Font) calls since it'll be recursively applied anyway.

Comment 6 Tod Creasey

2008-08-05 08:49:40 EDT

Patch looks fine. We can include it in M2.

Comment 7 Remy Suen

2008-11-16 09:26:48 EST

(In reply to comment #6)
> Patch looks fine. We can include it in M2.

Thanks for looking at it, Tod. I'll take over this bug and I'll try to get this into M4 since it didn't make it into M2.

Comment 8 Remy Suen

2008-11-16 09:27:38 EST

Whoops, forgot to leave Tod on CC.

Comment 9 Remy Suen

2008-11-30 05:34:43 EST

Fixed in HEAD. Slight modifications to attachment 108914 [details] because I missed a few setFont(Font) calls.
Available in builds > N20081129-2000.

Comment 10 Dani Megert

2008-11-30 08:00:05 EST

>Fixed in HEAD. Slight modifications to attachment 108914 [details] because I >missed a few
>setFont(Font) calls.
Shouldn't it be enough to call org.eclipse.jface.dialogs.Dialog.applyDialogFont(Control) on the top most parent?

Comment 11 Remy Suen

2008-11-30 08:02:34 EST

(In reply to comment #10)
> Shouldn't it be enough to call
> org.eclipse.jface.dialogs.Dialog.applyDialogFont(Control) on the top most
> parent?

I call it on 'composite' (though not on 'parent') on line 288. Are you seeing some problems, Dani? Or did you mean to suggest I should call it on 'parent' instead of 'composite'?

Comment 12 Remy Suen

2008-11-30 08:03:27 EST

Let me clarify comment 9, I missed _the removal_ of a few setFont(Font) calls. I'm not adding more, I'm removing them in favour of applyDialogFont(Control).

Comment 13 Dani Megert

2008-11-30 09:04:06 EST

>Let me clarify comment 9, I missed _the removal_ of a few setFont(Font) calls.
You hit the nail ;-)
Cheers.

Comment 14 Remy Suen

2008-12-09 11:26:37 EST

(In reply to comment #9)
> Fixed in HEAD.

Verified on I20081209-0100.