Bug 174348

Summary:

[classpath] Classpath validation messages are non-standard

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Core

Assignee:

Frederic Fusier <frederic_fusier>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

jerome_lanneluc, martinae, philippe_mulet

Version:

3.3

Target Milestone:

3.3 M6

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none
Updated regression tests	none
Proposed patch to fix all project quoting issues	none

Description Dani Megert

2007-02-15 13:08:52 EST

3.3 M5

The message that is generated for deprecated classpath variable initializers out of the values from the 'org.eclipse.jdt.core.classpathVariableInitializer' extension point does not adhere to UI standards:

Classpath variable 'JRE_LIB' in project Tests is deprecated: 'Use the JRE System Library instead' 

In the UI we use ' to flag arguments. Hence the message should be:
Classpath variable 'JRE_LIB' in project 'Tests' is deprecated. Use the JRE System Library instead.

Comment 1 Olivier Thomann

2007-02-15 13:15:24 EST

I'll fix it.

Comment 2 Olivier Thomann

2007-02-15 13:24:41 EST

"Use the JRE System Library instead" is an argument of the message.
So should it be between quotes?

Comment 3 Olivier Thomann

2007-02-15 13:25:59 EST

If we change this one, we have many others to change as well.

Comment 4 Dani Megert

2007-02-16 02:48:34 EST

>"Use the JRE System Library instead" is an argument of the message.
>So should it be between quotes?
Technically speaking yes, but for the user it's completely irrelevant. For him it is
1. what is deprecated
2. on which Java element
3. with what needs 1. be replaced

Let's start with improving this message and then fix the others step by step ;-)

Comment 5 Olivier Thomann

2007-02-16 14:52:55 EST

> In the UI we use ' to flag arguments. Hence the message should be:
> Classpath variable 'JRE_LIB' in project 'Tests' is deprecated. Use the JRE
> System Library instead.
I won't have the final '.'.
I'll wait till Monday to release it. Your test might rely on the current error message.

Comment 6 Olivier Thomann

2007-02-16 15:13:20 EST

I leave the ':' before the action to take since the one specified in the PR is not the only one.
So it would end up as:
Classpath variable 'JRE_LIB' in project 'Tests' is deprecated: Use the JRE
System Library instead

Is this ok ?

Comment 7 Olivier Thomann

2007-02-16 15:14:30 EST

Created attachment 59191 [details]
Proposed fix

Comment 8 Olivier Thomann

2007-02-16 15:14:43 EST

Created attachment 59192 [details]
Updated regression tests

Comment 9 Dani Megert

2007-02-19 03:36:52 EST

>Is this ok ?
It's beauty ;-)

Comment 10 Frederic Fusier

2007-02-19 07:25:32 EST

IMO we should use this bug to fix heterogeneous project quoting in classpath validation messages and not just fix the last added one.
It seems that I introduced this heterogeneity a long time ago while fixing bug 35567...

Comment 11 Frederic Fusier

2007-02-19 09:21:00 EST

Created attachment 59259 [details]
Proposed patch to fix all project quoting issues

Note that this patch fixes only issues with classpath messages, if other messages need similar changes, we'll open a new bug...

Comment 12 Frederic Fusier

2007-02-19 11:20:22 EST

Update summary according to final fix...

Comment 13 Frederic Fusier

2007-02-19 12:28:35 EST

Released for 3.3 M6 in HEAD stream.

Comment 14 Olivier Thomann

2007-03-20 09:56:40 EDT

Verified for 3.3 M6 using build I20070320-0010