Bug 169742

Summary: Export->Deployable Plugins notification should differentiate error from warning
Product: [Eclipse Project] JDT Reporter: Kevin McGuire <Kevin_McGuire>
Component: CoreAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED INVALID QA Contact:
Severity: normal    
Priority: P3    
Version: 3.3   
Target Milestone: 3.3 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
generated log files none

Description Kevin McGuire CLA 2007-01-05 18:51:10 EST 
Build N20061220-0010 3.3.0

1. Pick a plugin that has compilation warnings but no errors
2. Pick File->Export->Deployable Plugins 
3. You will get a notification at the end saying "Error"/"Errors occured during the operation.  A zip file..."

There were in fact no errors, just warnings.  It should differentiate.  As its written, I need to check every log file to make sure there wasn't a "real" problem.
Comment 1 Wassim Melhem CLA 2007-01-05 18:55:56 EST 
We only show the dialog when we get at least one error notification.  We don't show anything if it's all warnings.  So something fishy must be going on here.

What particular plug-in were you exporting?
Could you also attach the zip file containing the alleged errors?
Comment 2 Kevin McGuire CLA 2007-01-08 10:41:22 EST 
Curious.  I will retest.
Comment 3 Kevin McGuire CLA 2007-01-08 18:06:30 EST 
Created attachment 56597 [details]
generated log files

Btw, this was in build N1220

One log (JMusic_1.0.0) has only one message which I cannot tell if its a warning or error, there's nothing to say explicitly and there's no summary message at the bottom of the file. The others have a summary message at the bottom with warnings only.

The one of interest is:

# Eclipse Java Compiler 0.728, 3.3.0 milestone-5, Copyright IBM Corp 2000, 2006. All rights reserved.
File D:\eclipse workspaces\ArpEggDevel\JMusic\src\instruments\SawtoothInst.java is specified more than once

Note that there is no corresponding error in the IDE, which itself is another bug which I will log.  Also, I have no idea whatsoever what that error message is trying to tell me, perhaps someone can translate? :)
Comment 4 Olivier Thomann CLA 2007-01-09 11:25:56 EST 
I'll come to your office to debug this one.
Comment 5 Olivier Thomann CLA 2007-01-09 13:26:05 EST 
The error:
File D:\eclipse workspaces\ArpEggDevel\JMusic\src\instruments\SawtoothInst.java
is specified more than once

means it is an error. So PDE is right to return a dialog. We need to see why we got it.
Comment 6 Kevin McGuire CLA 2007-01-09 15:00:04 EST 
Error was not in the notification, will open a new bug to describe.