Bug 16846

Summary:

build.xml build script fails with Japanese characters

Product:

[Eclipse Project] PDE

Reporter:

John Arthorne <john.arthorne>

Component:

Assignee:

Dejan Glozic <dejan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

dj.houghton, rodrigo

Version:

2.0

Keywords:

Target Milestone:

2.0 F3

Hardware:

OS:

Windows 2000

Whiteboard:

Attachments:

Description	Flags
Contents of ant console after failure	none
build.xml with bogus characters	none
ZIP file containg build.xml file	none

Description John Arthorne

2002-05-22 11:15:09 EDT

Build: Freeze 1
Japanese Windows XP

1) Create a plugin project with japanese characters in the name
2) In the wizard, ensure the JAR filename also has japanese characters
3) Click on plugin.xml, and choose "Create plugin jars"
4) The AntRunner fails with an "Internal Error".  It tells you to consult the 
log file, but there is nothing in the log file.  I will attach the stack trace 
that appeared in the ant console.

It appears that the built-in Ant mkdirs task is failing, but I thought I 
should log it so we have a record of it.

Comment 1 John Arthorne

2002-05-22 11:15:39 EDT

Created attachment 946 [details]
Contents of ant console after failure

Comment 2 John Arthorne

2002-05-22 11:18:39 EDT

Correction:  the error message says, "See the Log console for more details", 
so this is correct.  The "Reason:" is given as: "Ant runner internal error".

Comment 3 John Arthorne

2002-05-22 11:22:58 EDT

Also attaching the build.xml file, which appears to have been generated 
incorrectly.  Note that in some places it has correctly inserted Japanese 
characters, but in other places it has just inserted ??? characters (for 
example as the jar name).  This might be the real cause of the above problem.

Comment 4 John Arthorne

2002-05-22 11:23:32 EDT

Created attachment 947 [details]
build.xml with bogus characters

Comment 5 John Arthorne

2002-05-22 11:26:06 EDT

It appears that Bugzilla can't handle text files with Japanese characters, so 
I will attach a ZIP file containing the build.xml file.

Comment 6 John Arthorne

2002-05-22 11:26:36 EDT

Created attachment 950 [details]
ZIP file containg build.xml file

Comment 7 Rodrigo Peretti

2002-05-23 18:17:02 EDT

We should try using the encoding option (Window->Preferences->Workbench->Work 
In Progress) and make sure all the important files (plugin.xml and 
build.properties) are using UTF-8 and see if we can still reproduce the 
problem. If it works we should consider a README on this one.

Comment 8 Rodrigo Peretti

2002-06-07 15:55:32 EDT

There are to problems here:

1) PDE Build is not writing the build.xml files ini UTF-8
2) PDE UI is not writing the build.properties file in the correct format 
defined by java.io.Properties

Comment 9 Rodrigo Peretti

2002-06-07 15:56:41 EDT

Fixed PDE Build. The build.xml files are now written in UTF-8. Moving to PDE 
UI for solving the issue with build.properties files.

Comment 10 Dejan Glozic

2002-06-08 12:51:11 EDT

Fixed by implementing encoding in BuildEntry model object. Values are now saved 
using unicode escape sequences for non-Ascii chars.