Summary: | SourceTypeConverter NPE in log | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Martin Aeschlimann <martinae> | ||||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | tobias_widmer | ||||||
Version: | 3.3 | ||||||||
Target Milestone: | 3.3 M5 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows NT | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Martin Aeschlimann
2006-12-14 12:31:45 EST
This can happen if the positions of the annotations would be wrong (start > end). A null check can easily be added. Philippe, do you want to add some logging for this? Did you work with annotations today? Yes, I was working an a quick fix that creates and uses annotations. I also got it twice two days ago, but no steps to reproduce. I think this can occurs when the annotation is located at the end of the file and that the source has changed before the source type converter was capable of retrieving a subset of the source code to parse the annotation value. bug 90916 showed a similar problem. I'll add a null check in the parseMemberValue method. Created attachment 55774 [details]
Proposed fix
Released for 3.3M5. No regression test. Please check the source code in order to verify that this is fixed. Created attachment 55775 [details]
Better patch
This prevents the method invocation and makes the code clearer.
Verified for 3.3 M5 using build I20070205-0009 *** Bug 96984 has been marked as a duplicate of this bug. *** |