Bug 161539

Summary: [Presentations] NPE in PresentablePart.getMenu
Product: [Eclipse Project] Platform Reporter: Martin Aeschlimann <martinae>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: ASSIGNED --- QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt
Version: 3.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Martin Aeschlimann CLA 2006-10-19 05:35:04 EDT
20061017-0800

I'm using the Extended VS Presentation which stopped working in 20061017-0800.
The stacktrace looks as this could be a problem in platform ui.


http://www.eclipseplugincentral.com/Web_Links-index-req-viewlink-cid-586.html

java.lang.NullPointerException
	at org.eclipse.ui.internal.presentations.PresentablePart.getMenu(PresentablePart.java:261)
	at de.loskutov.eclipseskins.ui.PartTitle.setBounds(PartTitle.java:364)
	at de.loskutov.eclipseskins.presentation.VSViewStackPresentation.layout(VSViewStackPresentation.java:69)
	at de.loskutov.eclipseskins.presentation.VSViewStackPresentation.childPropertyChanged(VSViewStackPresentation.java:222)
	at de.loskutov.eclipseskins.presentation.VSStackPresentation$2.propertyChanged(VSStackPresentation.java:233)
	at org.eclipse.ui.internal.presentations.PresentablePart.firePropertyChange(PresentablePart.java:112)
	at org.eclipse.ui.internal.presentations.PresentablePart$1.propertyChanged(PresentablePart.java:88)
	at org.eclipse.ui.internal.PartPane.firePropertyChange(PartPane.java:594)
	at org.eclipse.ui.internal.ViewPane.toolBarResized(ViewPane.java:161)
	at org.eclipse.ui.internal.ViewPane.access$0(ViewPane.java:149)
	at org.eclipse.ui.internal.ViewPane$ISVPropListener.propertyChange(ViewPane.java:79)
	at org.eclipse.jface.internal.provisional.action.ToolBarManager2.firePropertyChange(ToolBarManager2.java:144)
	at org.eclipse.jface.internal.provisional.action.ToolBarManager2.firePropertyChange(ToolBarManager2.java:157)
	at org.eclipse.jface.internal.provisional.action.ToolBarManager2.relayout(ToolBarManager2.java:167)
	at org.eclipse.jface.action.ToolBarManager.update(ToolBarManager.java:348)
	at org.eclipse.ui.internal.ViewPane.updateActionBars(ViewPane.java:443)
	at org.eclipse.ui.internal.ViewActionBars.updateActionBars(ViewActionBars.java:59)
Comment 1 Kim Horne CLA 2006-10-19 13:02:48 EDT
Eric?
Comment 2 Eric Moffatt CLA 2006-10-19 13:19:08 EDT
Martin, are you using the experimental 3.3 presentation or the default one?
Comment 3 Martin Aeschlimann CLA 2006-10-20 05:56:20 EDT
An externally contributed presentation, the 'Extended VS Presentation', see link on comment 0.
Comment 4 Eric Moffatt CLA 2006-10-20 10:05:53 EDT
Martin, can you fill me in with a bit more info. I've been making changes around this area (specifically handling Min/Max) but can't see how it could have affected the menu operations.

Does the exception occur on startup or in response to some operation?
If the latter...which operation?
Comment 5 Martin Aeschlimann CLA 2006-10-20 10:13:09 EDT
After startup of an existing workpace configured with that presentation, views couldn't be opened.

Did you try the presentation plugin?
Comment 6 Eric Moffatt CLA 2006-10-20 10:51:34 EDT
Just tried it against both 20061010-0800 & 20061017-0800. I don't get an NPE.

Are there custom views / plugins involved here?
Does the same workspace open without issues in earlier builds?
Comment 7 Paul Webster CLA 2006-10-20 11:50:59 EDT
It looks like the PartPane part==null ... the first thing we do is set the PartPane, and during a dispose we remove the property change listeners and then null out the part pane.

Martin, do you have the full stack trace (and any other errors in you error log)?

Also, this problem is workspace specific?  If it is, could you please attach .metadata/.plugins/org.eclipse.ui.workbench/workbench.xml for the workspace that it fails.

PW
Comment 8 Eclipse Webmaster CLA 2019-09-06 15:31:05 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.