Summary: | org.eclipse.jdt.internal.core.NamedMember#getFullyQualifiedParameterizedName probably boggus | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Olivier Thomann <Olivier_Thomann> | ||||
Component: | Core | Assignee: | Jerome Lanneluc <jerome_lanneluc> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | Olivier_Thomann, pugh | ||||
Version: | 3.3 | ||||||
Target Milestone: | 3.3 M3 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Olivier Thomann
2006-10-18 10:10:42 EDT
Found by findbugs http://findbugs.blogspot.com/2006/09/how-do-you-fix-obvious-bug.html The type argument doesn't contain '/' anymore. The call: String[] typeArguments = new BindingKey(uniqueKey).getTypeArguments(); returns a string[] where '/' have been replaced with '.'. So no need to do it again. Jérôme, Could you please double-check that I didn't miss anything? org.eclipse.jdt.core.tests.model.ResolveTests_1_5#test0083 seems to be a regression test for this case. Thanks. Created attachment 52610 [details]
Proposed fix
Released for 3.3M3. All tests passed including existing ResolveTests_1_5#test0083. Jérôme, just confirm that '/' cannot be inside typeArguments. The call typeArgument.replace('/', '.') is a noop. The spec of BindingKey#getTypeArguments() doesn't specify whether the signature is dot separated or slash separated. However the current implemation of BindingKey#getTypeArguments() always returns a dot separated signature. Since we control both implementations and since we have a regression test, the change is ok. Verified code using History... |