Summary: | [classpath] Util.getJDKLevel reading a lot of classpath jars because ClasspathEntry checks for string object reference instead of equals | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Raj Mandayam <ramanday> |
Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P3 | CC: | bokowski, jcagle, john.arthorne, kaishaddadin, laffrac, nagrawal, philippe_mulet, steven.wasleski |
Version: | 3.2 | Keywords: | performance |
Target Milestone: | 3.2.2 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Raj Mandayam
2006-09-29 13:42:33 EDT
Excellent find, we shouldn't be using identity compare here. Frederic - pls check other instances (all refs to CompilerOptions fields). May want to backport to 3.2.2, since this may be a big performance issue for some usecases. We need this fix to be targeted for 3.2.2 (if not any lower) because the product depends on this version. Hence raising it to critical. Philippe, OK to set target to 3.2.2 ? +1 for 3.2.2 Chris - Can you double check the fix has the nice consequences we expect in term of performance ? i.e. Do we get stuck again elsewhere after this ? Frederic - can you pls post a 3.2.2 preview with the fix in ? Sure. I can try this out. Released for 3.3 M2 in HEAD stream. Test cases added in ClasspathTests: - #testClasspathValidation27_Bug159325_project() - #testClasspathValidation27_Bug159325_lib() Backport to 3.2.2 will be done today... Released for 3.2.2 in R3_2_maintenance stream. I've posted corresponding preview at: http://www.eclipse.org/jdt/core/r3.2/index.php#UPDATES Raj or Chris, could you let us know what the gain was for your large workspace scenario? Hi Steve, Before this fix, I would see in 10 min of building the workspace I/O Read bytes grow to 10 gb, after the fix, in 10 min I/O Read bytes is at 1-2 gb. So really good improvement. *** Bug 159872 has been marked as a duplicate of this bug. *** Comment 8 should read "Released for 3.3 M3" instead! (In reply to comment #12) > *** Bug 159872 has been marked as a duplicate of this bug. *** > This is not a duplicate... Verified for 3.2.2 using build M20070112-1200 *** Bug 146745 has been marked as a duplicate of this bug. *** |