Bugzilla – Full Text Bug Listing
| Summary: | Set 'generatedBy' attribute of IMarker anywhere markers are generated in JDT/Core code | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> | ||||||||
| Component: | Core | Assignee: | Maxime Daniel <maxime_daniel> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | 3.3 | ||||||||||
| Target Milestone: | 3.3 M4 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Frederic Fusier
Builder issue. We also have markers issued by the JavaModel, ie. buildpath markers. All of them should be stamped accordingly. I have prepared a patch that sets that attribute to JavaCore.PLUGIN_ID (currently under test, instrumented to catch failed cases). Frédéric, please let me know if this is the intended value for all our markers, or if you want another one. Created attachment 54777 [details]
Fix (using JavaCore.PLUGIN_ID as marker)
Would still need a few tests to check we do not miss that attribute under diverse circumstances.
Created attachment 54877 [details]
Fix + test cases - still using JavaCore.PLUGIN_ID
Note:
- need to discuss with clients to define what is needed (JavaCore.PLUGIN_ID, something else...);
- need to dig deeper the compiler participant generated problems case.
Pinged JohnA. Feedback from JohnA is that we should use a shorter key if possible, aka "JDT". Discussed with Philippe: we'll check other potential uses (as of today) and go for a JDT key if no indication that something else would be better. As far as compilation participants are concerned, we'll hand out the responsibility to them, carrying the attribute if they set it on the categorized problems (need to document that). Found no reference to IMarker#GENERATED_BY in a full Eclipse source workspace, hence will go for "JDT". Created attachment 55194 [details]
Fix + test cases using JavaBuilder#GENERATED_BY
This patch does the following:
- IMarker-s generated by JDT get JavaBuilder#GENERATED_BY, currently valued to JDT, as their IMarker#GENERATED_BY attribute;
- IMarker-s originating from compiler participants' categorized problems which do not have the IMarker#GENERATED_BY extra attribute set do not have their GENERATED_BY attribute set;
- IMarker-s originating from compiler participants' categorized problems which have the IMarker#GENERATED_BY set to a given value get their GENERATED_BY attribute set to the said value.
Verifier please consider ParticipantBuildTests #1001 and 1002 and ErrorsTests #100 to 104. Released for 3.3 M4. Verified for 3.3M4 with I20061211-1119. Tests passed. |