Summary: | UnresolvedReferenceBindings surfacing through DOM AST | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Walter Harley <eclipse> | ||||||||||||
Component: | Core | Assignee: | Maxime Daniel <maxime_daniel> | ||||||||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||||||||
Severity: | normal | ||||||||||||||
Priority: | P3 | CC: | jgarms, kent_johnson, philippe_mulet | ||||||||||||
Version: | 3.2 | ||||||||||||||
Target Milestone: | 3.2.2 | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Windows XP | ||||||||||||||
Whiteboard: | |||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 527462 | ||||||||||||||
Attachments: |
|
Description
Walter Harley
2006-08-24 16:55:40 EDT
Created attachment 48644 [details]
jar file with binary types and anno def
Created attachment 48645 [details]
processor plug-in project
Created attachment 48646 [details]
debug target project
Added regression test org.eclipse.jdt.core.tests.dom.ASTConverter15Test#test0227 in HEAD. The test is disabled for now. Maxime, Please give it a try? Kent can help you in case of problems. Created attachment 49405 [details]
Tentative patch
Released for 3.3 M2 (May have minimized the changes, but I really wanted to clarify the situation around createUnresolvedAnnotation.) Verifier please use the original test case, or else ASTConverter15Test#test0227. Thanks! Much appreciated. I'm traveling today, won't be able to verify until this Friday but will do it then. Am I correct that this fix would also work for 3.2? We'd like to get it applied there as well, at least for 3.2.2 if it is too late for 3.2.1. This isn't planned for 3.2.1 (too late and too risky). We can consider backporting it post 3.2.1, and posting a patch. Then maybe it makes it into 3.2.2 I'm still seeing the behavior in I20060906-1200. But maybe it didn't make it in time for that build? I'm downloading N20060908-0010 right now, will try it there. Verified in v3.3 N20060908-0010. Thanks, Maxime! I would appreciate it if we could include this in 3.2.2, as well. (In reply to comment #11) > Verified in v3.3 N20060908-0010. Thanks, Maxime! You're welcome. > I would appreciate it if we could include this in 3.2.2, as well. Philippe's call. I'll wait until 3.2.1 is declared anyway. +1 for 3.2.2, BUT we may want a reduced fix for 3.2.2 (i.e. just the one change to address the bug, vs. the bigger change made for 3.3 stream). Need to interact with Kent to narrow the change to reasonable subset. Reopening for 3.2.2 Created attachment 51753 [details]
Reduced fix for the 3.2 maintenance branch, plus test cases.
I believe this fix is narrowly focused on the problem at hand. Kent please let me know if you disagree.
Released for 3.2.2. Verified for 3.2.2 using build M20070112-1200 |