Summary: | Support for multiple build consoles | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Tools] CDT | Reporter: | Jeff Johnston <jjohnstn> | ||||||
Component: | cdt-core | Assignee: | Anton Leherbauer <aleherb+eclipse> | ||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||
Severity: | enhancement | ||||||||
Priority: | P3 | CC: | cdtdoug, jjohnstn, norbert.ploett, overholt | ||||||
Version: | 4.0 | Keywords: | contributed | ||||||
Target Milestone: | 4.0 M5 | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Jeff Johnston
2006-08-14 15:29:52 EDT
Created attachment 47864 [details]
CDT UI patch to support secondary build consoles
Anyone have time to take a look at this? We're trying to get the GNU Autotools project patch-clean (ie. no patches to the CDT itself). Changing to 4.0. Could you update the patch based on current HEAD? It does not apply cleanly. Furthermore, - it should be warning free (non-externalized strings, etc.) - refactor the two almost identical BuildConsoleManager.startup methods - a single id for menuId and contextMenuId should be sufficient (only the id to register the context menu is actually relevant) - define a constant for the default contextMenuId and keep it the same as before (menu ids are API) - the provided contextMenuId should be used as is (ie. without prefixing the cdt.ui plugin id) - why "sub"console? there is no super console (only a default) - add yourself to the contributors list in the copyright notice Thanks! Created attachment 57870 [details]
CDT UI patch to support multiple build consoles
(In reply to comment #4) > Could you update the patch based on current HEAD? It does not apply cleanly. > Furthermore, > - it should be warning free (non-externalized strings, etc.) > - refactor the two almost identical BuildConsoleManager.startup methods > - a single id for menuId and contextMenuId should be sufficient (only the id to > register the context menu is actually relevant) > - define a constant for the default contextMenuId and keep it the same as > before (menu ids are API) > - the provided contextMenuId should be used as is (ie. without prefixing the > cdt.ui plugin id) > - why "sub"console? there is no super console (only a default) > - add yourself to the contributors list in the copyright notice > Thanks! > New patch created that applies to HEAD. Tested on M4 with simple ManagedMake hello world project to verify console works fine. The patch has been cleaned up (rewritten) significantly thanks to your excellent comments. I preserved the old context menu id as requested (including spelling error for Conole instead of Console). I re-commented it to be "multiple build console support" which is more appropriate and easier to understand. The CUIPlugin just has one extra method for getting a console manager using a name and id. The default getConsoleManager method is still around and calls the new method with appropriate defaults for name and id. Let me know if there are any other problems. Thanks. Thanks for the update, that's exactly what I had in mind. I have applied the patch with 2 minor changes: - renamed the context menu id constant to DEFAULT_CONTEXT_MENU_ID - moved the resource string for the console name assigning done |