Bug 151640

Summary:	[encapsulate field] display all visibility modifiers
Product:	[Eclipse Project] JDT	Reporter:	Max Gilead <max.gilead>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3
Version:	3.2
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Max Gilead

2006-07-24 16:38:22 EDT

The title says it all: 'Encapsulate field' refactoring is missing default (friendly) access modifier.

Comment 1 Max Gilead

2006-07-24 16:55:08 EDT

Errr.. whoops. It's there, just invisible when encapsulating protected field. Changing bug title to ''Encapsulate field' refactoring dialog should display all options, including disabled ones' -- IMHO user should be able to refactor even public field to private one with private setter/getter but I guess it's done like currently for a reason.
I believe that not showing disabled option is bad UI design and I suggest to show all options, including disabled ones.

Comment 2 Martin Aeschlimann

2006-07-25 06:33:33 EDT

I guess the rational was that an accessor can not have a smaller visibility than the field. But this is something that the sure maybe knows better.

I would also show all options and warn later if the visibility is not good enough.