Summary: | Startup fails if .project has argument key with no value | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Simon Arsenault <simon_arsenault> |
Component: | Resources | Assignee: | DJ Houghton <dj.houghton> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P1 | ||
Version: | 2.0 | ||
Target Milestone: | 2.0 M6 | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
Description
Simon Arsenault
2002-04-30 14:48:52 EDT
Out of curiousity, how would you do this via code? (since I don't believe that Maps allow you to have null as values) You are allowed to use null for a value (as long as the implementation supports it). Also, it is possible the value could be an empty string which would give the same result. I'm running into this problem for the tool script support. I'd like to release this code by thursday but can't if this problem exist. Not sure if this will be able to be fixed by Thursday. The case of key -> "" is an interesting one and I'm not sure how we can preserve that in the file. Will think about it. Fixed and released to HEAD. Please note that your code which sets the builder command argument values to be null should be changed if you are relying on null coming back as the value across sessions. Upon further review of the ICommand spec, it says that the Map of arguments contains Strings only as both the keys and the values. With this assumption, the Reader code which reads from the XML file on disk was changed so when we come across an XML file with an empty tag it is assumed that the value is an empty String and not null. I've already made the change so that the argument value is always a string, not a null. Could the ICommand docs be updated a bit. When you see: * @return a table of command arguments (key type : <code>String</code> * value type : <code>String</code>), or <code>null</code> it hard to notice that ")" character in the second line. At a quick glance, it looks like value type is either string or null. Is this better? * @param args a table of command arguments (keys and values must * both be of type <code>String</code>), or <code>null</code> Yes, better. Updated and released code comment. |