Summary: | [compiler][batch][options] tighten the use of : and ; within access restriction specifications | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Maxime Daniel <maxime_daniel> | ||||
Component: | Core | Assignee: | Maxime Daniel <maxime_daniel> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | Olivier_Thomann | ||||
Version: | 3.2 | ||||||
Target Milestone: | 3.3 M6 | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Bug Depends on: | 161996 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Maxime Daniel
2006-06-16 11:17:06 EDT
While this bug does not need bug 161996 to be resolved before we can tackle it, it is expected that the other bug will introduce changes that will impact the solution for this bug. After thinking more about it, I would no more support the 'tolerant' approach too much. Arguments: - classpath entries are not tolerant to ':' use as path separator on W*, hence being tolerant inside rules has little added value; - ':' is used in all absolute pathnames on W*; keeping the current obligation to use ';' as the rule separator should thus keep command lines more readable; attempting to sort out legit ':' in paths from uses of ':' instead of ';' as rules separator may also complicate the state machine and raise costs above the expected benefits. Having said that, I'll only fix the messages that wrongly suggest to use ':' as a rule separator on W*. Created attachment 60253 [details]
Suggested fix
Released for 3.3 M6. Is PDE/Build aware of this fix? I do not think it is necessary since I only changed the help message. The impact should only be on our doc, right? I thought that PDE/Build were always using ':'. If they did, they would not get the rules to work at all, cause +OK:-KO is (and was) interpreted as 'plus upon path OK:-KO', which fails silently to match anything at all (no 'OK:-KO' path - in general). Verified for 3.3 M6 using build I20070319-1335 |