Bug 145047

Summary:

use chars instead of strings to process signatures in UnresolvedType

Product:

[Tools] AspectJ

Reporter:

Helen Beeken <hlhawkins>

Component:

Compiler

Assignee:

aspectj inbox <aspectj-inbox>

Status:

NEW ---

QA Contact:

Severity:

enhancement

Priority:

CC:

aclement

Version:

DEVELOPMENT

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
possible start of implementation	none

Description Helen Beeken

2006-06-02 08:17:13 EDT

Strings are currently used within UnresolvedType.signatureToName() and UnresolvedType.nameToSignature() whereas chars would be more effient.

Comment 1 Helen Beeken

2006-06-02 08:23:25 EDT

Created attachment 43344 [details]
possible start of implementation

This came about whilst investigating bug 141730. Before realizing that the work is done for you within UnresolvedType (doh :-)) I wrote my own converter from signatures like 'Ljava/lang/String' and 'I' to 'java.lang.String' and 'int' all in terms of chars. Comparing this with the implementation in UnresolvedType the logic is pretty similar.

The attached patch is a patch to the asm project and adds methods equivalent to UnresolvedType.signatureToName() and UnresolvedType.nameToSignature() to ProgramElement (called createReadableName() and getTypeName()). It also contains a typesafe enum SignatureType and a helper class CharOperation (because from the asm project you can't see the compiler CharOperation class)

Comment 2 Andrew Clement

2007-10-24 10:03:48 EDT

decide on what to do here

Comment 3 Andrew Clement

2013-06-24 11:02:15 EDT

unsetting the target field which is currently set for something already released