Bug 142808

Summary:

Consider using a flat transaction in CompositeTransactionalCommands

Product:

[Modeling] GMF-Runtime

Reporter:

Christian Damus <give.a.damus>

Component:

General

Assignee:

Linda Damus <ldamus>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Keywords:

investigate, performance

Version:

1.0

Target Milestone:

1.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Possible update to the AbstractEditHelper	none

Description Christian Damus

2006-05-19 13:36:17 EDT

It may be worth considering the potential performance benefits of using the new "flat transaction" capability of the CompositeEMFOperation in GMF's CompositeTransactionalCommand, implemented by bug 141051.  This could be especially useful for the command created for DestroyElementRequests, as these are known to be potentially quite large.

Comment 1 Christian Damus

2006-05-19 13:39:27 EDT

Created attachment 42047 [details]
Possible update to the AbstractEditHelper

Attached a patch that demonstrates the performance impact by updating the AbstractEditHelper to always disable transaction nesting.  It seems to work in the logic example at least, but may not be applicable in all cases.

Comment 2 Linda Damus

2006-05-30 15:59:49 EDT

Tested and committed the patch.

Comment 3 Richard Gronback

2008-08-13 13:05:28 EDT

[target cleanup] 1.0 RC4 was the original target milestone for this bug

Comment 4 Eclipse Webmaster

2010-07-19 21:55:27 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime Common was the original product and component for this bug