Bug 142033

Summary:	Shape and connector factories should use the same mechanism to obain editing domain
Product:	[Modeling] GMF-Runtime	Reporter:	Natalia Balaba <nbalaba>
Component:	General	Assignee:	Cherie Revells <crevells>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	P1
Version:	unspecified
Target Milestone:	1.0
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Natalia Balaba

2006-05-16 13:13:28 EDT

It is a simple fix, which has a really big impact. BasicNodeViewFactory has getEditingDomain() method, which should be propagated up the hierarchy. When ConnectionViewFactory creates a view, it should call this method to obtain editing doman rather then TransactionUtil.getEditingDomain(edge). The BasicNodeViewFactory way of obtaining it goes a step futher - it looks for the editing domain of the semantic element (is there is one) first. In some cases we do want to have views which are not attached to a resource, but thier semantic element is.

Comment 1 Cherie Revells

2006-05-16 14:32:48 EDT

Purpose: 
Bugzilla#142033 Shape and connector factories should use the same mechanism to obain editing domain
- Moved method getEditingDomain(EObject semanticElement, View containerView) from BasicNodeViewFactory to its parent AbstractViewFactory so that it can be called from ConnectionViewFactory as well.

Activities: 
Bugzilla#142033 gmf_head cmahoney 050516 Shape and connector factories should use the same mechanism to obtain editing domain

Code Reviewed by:
Linda

Comment 2 Richard Gronback

2008-08-13 13:05:03 EDT

[target cleanup] 1.0 RC3 was the original target milestone for this bug

Comment 3 Eclipse Webmaster

2010-07-19 12:30:27 EDT

[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug