Bug 138999

Summary: Regression: Fix for 128258 introduces regression in JavaProject.exists()
Product: [Eclipse Project] JDT Reporter: Harold Gartner <hgartner>
Component: CoreAssignee: Jerome Lanneluc <jerome_lanneluc>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: benson.ning, daniel_megert, philippe_mulet
Version: 3.2   
Target Milestone: 3.2 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed patch and regression test none

Description Harold Gartner CLA 2006-04-27 12:59:40 EDT
+++ This bug was initially created as a clone of Bug #128258 +++

I20060216-0010

- open a java file from the CVS Repositories view
- select two members in the Outline
- choose Compare With > Each Other...

The element names are rendered with postfix _E_X_T_E_R_N_A_L_P_R_O_J_E_C_T_

We have a UI that allows users to type in the name of an existing project.  We use the JavaProject.exists() method to determine whether the project exists or not.  If it doesn't, then we issue an error message.  If the user types a space character for the name of the project, then the JavaProject.exists() method is now returning 'true' where it used to always return 'false'.  This is a regression in function.  ' ' is not a valid name for the project and since the validation is saying that it is, our downstream tooling fails because the project is not valid.
Comment 1 Jerome Lanneluc CLA 2006-04-28 11:46:42 EDT
Created attachment 39789 [details]
Proposed patch and regression test
Comment 2 Philipe Mulet CLA 2006-05-02 10:14:00 EDT
+1 for 3.2RC3.

Dani - pls cast your vote
Comment 3 Dani Megert CLA 2006-05-02 10:30:10 EDT
+1 for 3.2 RC3.
Comment 4 Jerome Lanneluc CLA 2006-05-02 11:03:02 EDT
Released patch and regression test
Comment 5 Olivier Thomann CLA 2006-05-03 10:43:51 EDT
Verified using N20060503-0010 for 3.2RC3
Comment 6 Frederic Fusier CLA 2006-05-04 10:50:07 EDT
Double-checked using N20060504-0010 + v_663